Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to jest 23 #507

Merged
merged 1 commit into from Oct 21, 2018
Merged

chore: upgrade to jest 23 #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -49,6 +49,8 @@
"stringify-object": "^3.2.2"
},
"devDependencies": {
"babel-core": "^6.26.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peer dep of babel-jest (due to us supporting both babel 6 and 7)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be possible for us to remove babel from the project? I don't mind not using import but being more strict on what features are allowed. Last time it confused me a lot since tests are relying on it but source code doesn't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably. Especially if you start using node 8, as you have object spread and async await out of the box 馃檪

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. Here is the issue to track #508 ;)

"babel-jest": "^23.6.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To work with yarn plug n play, it's important to not rely on hoising

"babel-plugin-transform-object-rest-spread": "^6.26.0",
"babel-preset-env": "^1.6.0",
"commitizen": "^2.9.6",
Expand All @@ -58,7 +60,7 @@
"eslint-config-okonet": "^5.0.1",
"eslint-plugin-node": "^6.0.0",
"husky": "^0.14.3",
"jest": "^22.4.0",
"jest": "^23.6.0",
"jsonlint": "^1.6.2",
"prettier": "1.11.1"
},
Expand Down