Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loadConfig.js #1320

Closed
wants to merge 3 commits into from
Closed

Update loadConfig.js #1320

wants to merge 3 commits into from

Conversation

mauro-ni
Copy link

@mauro-ni mauro-ni commented Sep 2, 2023

This pull request should address #1319

@mauro-ni mauro-ni mentioned this pull request Sep 2, 2023
Open
@iiroj
Copy link
Member

iiroj commented Sep 4, 2023 •
edited

Looks like npm@10 doesn't support Node.js 16 anymore and fails the CI jobs. The CI workflow needs to be updated to install npm@9, or then we just release a new breaking change and drop support for Node.js 16 too...

@iiroj
Copy link
Member

iiroj commented Oct 14, 2023

Closing as this doesn't seem to be passing in tests. Feel free to re-open if you figure it out!

@iiroj iiroj closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mauro-ni @iiroj