M3-6013: Resolve loader-utils Dependabot
#8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
bnussman-akamai
commented
Dec 13, 2022
| @@ -38,47 +35,6 @@ export const getNodeBalancers = () => { | |||
| return nodeBalancerFactory.buildList(10).map((nb) => ({ ...nb, configs })); | |||
| }; | |||
|
|
|||
| # Entity Detail | |||
|
|
|||
| ## Volumes | |||
There was a problem hiding this comment.
Volumes and Domains don't use <EntityTable /> anymore so this story was broken. Removing so the story works for now and we can revisit later.
bnussman-akamai
commented
Dec 14, 2022
| @@ -232,7 +232,6 @@ | |||
| "reselect-tools": "^0.0.7", | |||
| "serve": "^14.0.1", | |||
| "source-map-loader": "^4.0.1", | |||
| "storybook-react-router": "~1.0.8", | |||
There was a problem hiding this comment.
This package is not used
cpathipa
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
@bnussman-akamai Overall LGTM! Thank you for doing cleanup work and lifting unused imports.
mjac0bs
approved these changes
Dec 14, 2022
bnussman-akamai
added a commit
that referenced
this pull request
Jan 4, 2023
* update packages that need `loader-utils` and pin it * update `yarn.lock` * update comment about `require()` * use `swc` for Storybook because babel cries using the lastest pinned `loader-utils` * use `loader-utils@2.0.4` * revert out of scope changes * use older version of `tsup` becuase rollup 3 does not support our node version Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
loader-utilsbut also adds a yarn resolution because many packages we depend on still use a very old version of it@types/reactto17.x.xusing Yarn resolution so we can regenerate our yarn.lock without yarn pulling@types/react@18tsupto use an older version because newer versions use rollup 3 which do not allow you to use our version node 14yarn why loader-utilsThese are the packages blocking us from not using a yarn resolution
@storybook/builder-webpack4#loader-utils@1.4.2@storybook/manager-webpack4#loader-utils@1.4.2babel-loader#loader-utils@1.4.2webpack#loader-utils@1.4.2css-loader#loader-utils@1.4.2How to test 🧪