logging: update tracing and tracing-subscriber
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to the latest versions of the `tracing` and `tracing-subscriber` crates picks up a few changes that might be relevant to us: - tokio-rs/tracing#333: Fix an issue where filtering directives could sometimes be ignored - tokio-rs/tracing#344: Fix for filters not applying to events generated from `log` records - tokio-rs/tracing#346: Dependencies using `tracing`'s `log` back-compat alongside the `log` record to `tracing` event conversion layer will no longer result in duplicate events Additionally, `tracing-subscriber` 0.1.2 removed some dependencies that were previously on by default, and feature flagged others; I've tweaked the feature flags that we enable so we now have fewer transitive deps in our lockfile :D Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: hawkw <eliza@buoyant.io>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 18, 2019
This change updates the internals of the proxy's client to the Destination controller. Other than some minor fixes to the client's backoff logic, no user-facing changes are expected. * Split service discovery into composable components (linkerd/linkerd2-proxy#341) * logging: update `tracing` and `tracing-subscriber` (linkerd/linkerd2-proxy#352) * resolve: Do not send the 'k8s' scheme (linkerd/linkerd2-proxy#356)
alpeb
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 18, 2019
This change updates the internals of the proxy's client to the Destination controller. Other than some minor fixes to the client's backoff logic, no user-facing changes are expected. * Split service discovery into composable components (linkerd/linkerd2-proxy#341) * logging: update `tracing` and `tracing-subscriber` (linkerd/linkerd2-proxy#352) * resolve: Do not send the 'k8s' scheme (linkerd/linkerd2-proxy#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to the latest versions of the
tracingandtracing-subscribercrates picks up a few changes that might berelevant to us:
PartialOrdimpls forDirectives tokio-rs/tracing#333: Fix an issue where filtering directives couldsometimes be ignored
tracing-logevents tokio-rs/tracing#344: Fix for filters not applying to events generatedfrom
logrecordstracing'slogback-compatalongside the
logrecord totracingevent conversion layer will nolonger result in duplicate events
Additionally,
tracing-subscriber0.1.2 removed some dependencies thatwere previously on by default, and feature flagged others; I've tweaked
the feature flags that we enable so we now have fewer transitive deps in
our lockfile :D
Signed-off-by: Eliza Weisman eliza@buoyant.io