Add environment variables to configure HTTP/2 keepalive timeout and interval configuration from environment variables #2803
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add environment variables to configure HTTP/2 keepalive timeout and interval Problem There is no way to configure timeout and interval via environment variables Solution Add environment variables to configure HTTP/2 keepalive timeout and interval Validation Fixes #[12269] Signed-off-by: UsingCoding <extendedmoment@outlook.com>
…s still possible to specify the timeout for HTTP/2 separately Signed-off-by: UsingCoding <extendedmoment@outlook.com>
…control plane. The keepalive timeout for the control plane should be different than for proxy connections Signed-off-by: UsingCoding <extendedmoment@outlook.com>
|
@UsingCoding thanks. I've been waiting to sync up with more of the team on how to proceed here. The environment-based approach is really not how we want to expose this sort of configuration, ultimately -- it's the wrong granularity of configuration. We should really be configuring this per server and per client (and not on the workload broadly). So we've treated the environment variables as a developer escape hatch for testing and never really wanted to show this configuration directly to users. That said, adding non-environment configuration is quite a bit more work, so I'm sympathetic to simply exposing what we have today. I'll talk to the team and come back with clearer guidance on how to proceed. |
UsingCoding
added a commit
to ispringtech/linkerd2-proxy
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add environment variables to configure HTTP/2 keepalive timeout and interval
Problem
There is no way to configure timeout and interval via environment variables.
Solution
Configure keepalive timeout and interval for inbound/outbound by
LINKERD2_PROXY_{INBOUND,OUTBOUND}_HTTP2_KEEPALIVE_{TIMEOUT,INTERVAL}Fixes linkerd/linkerd2#12269