Update Router to wait for inner poll_ready before calling inner call #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
reviewed
Feb 21, 2019
| NoCapacity(usize), | ||
| NotRecognized, | ||
| Invalid, | ||
| NotReady(Req, Svc), |
There was a problem hiding this comment.
These state transitions can be extracted to a shared Oneshot utility in tower-util. (not saying this PR should do it).
Signed-off-by: Sean McArthur <sean@buoyant.io>
seanmonstar
force-pushed
the
router-clone-ready
branch
from
9672f4d
to
d59863e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract to only call
Service::callafter seeing ready frompoll_readywas just made strong. So, this one step towards making sure we do just that.Since a router can't call
poll_readyon all of its inner routes, instead it requires each service beClone, and callspoll_readyin itsResponseFuture.