Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prepare hook for building directly from source (GitHub) #560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RinkeHoekstra
Copy link
Contributor

@RinkeHoekstra RinkeHoekstra commented Jul 19, 2022

A standard npm install from source (especially GitHub) did not build all of the packages in lib, dist and esm.

This adds a prepare hook in package.json that ensures that everything is built properly before the rdflib packages is added to node_modules.

This fixes #559

@angelo-v
Copy link
Contributor

I am not sure if I get what you are trying to achieve. Are you taking about something like npm install git+ssh://...?

I am against using the prepare hook to build things, as it slows down every npm install. If you want to build, then use the build scripts. If you need to install dev snapshots that match the github code, then we should publish them via the pipeline. You can also checkout and build the github code and then install the local module in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Installing from GitHub source will not include lib, dist and esm folders
3 participants