Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect unicode chars in t macro #1032

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix: respect unicode chars in t macro #1032

merged 1 commit into from
Apr 8, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Apr 8, 2021

Will unblock the migration of #1022

@vercel
Copy link

vercel bot commented Apr 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/DeRDexAuswbirT85GZtm3kEVnemH
✅ Preview: https://js-lingui-git-fix-unicode-chars-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1032 (9ebae95) into main (76553af) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   83.35%   83.21%   -0.15%     
==========================================
  Files          53       53              
  Lines        1622     1626       +4     
  Branches      436      441       +5     
==========================================
+ Hits         1352     1353       +1     
- Misses        157      158       +1     
- Partials      113      115       +2     
Impacted Files Coverage Δ
packages/macro/src/macroJsx.ts 91.11% <0.00%> (-0.68%) ⬇️
packages/macro/src/macroJs.ts 91.11% <100.00%> (+0.06%) ⬆️
packages/core/src/context.ts 82.35% <0.00%> (-3.65%) ⬇️
packages/conf/src/index.ts 80.76% <0.00%> (ø)
...ackages/babel-plugin-extract-messages/src/index.ts 82.40% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76553af...9ebae95. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.73 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)

@semoal semoal merged commit 7597621 into main Apr 8, 2021
@semoal semoal deleted the fix-unicode-chars branch April 8, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants