Migrate unit tests to JUnit 5 (Part 1) #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarboniteKream
requested review from
ikhoon,
minwoox and
trustin
as code owners
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
============================================
- Coverage 69.9% 69.89% -0.02%
Complexity 3149 3149
============================================
Files 325 325
Lines 12672 12674 +2
Branches 1348 1348
============================================
Hits 8858 8858
- Misses 2963 2966 +3
+ Partials 851 850 -1
Continue to review full report at Codecov.
|
ikhoon
reviewed
Jan 21, 2020
| List<Endpoint> decoded = decoder.decode(HOST_AND_PORT_LIST.stream().collect(Collectors.joining("\n"))); | ||
| void decode() { | ||
| final EndpointListDecoder<String> decoder = EndpointListDecoder.TEXT; | ||
| final List<Endpoint> decoded = decoder.decode(String.join("\n", HOST_AND_PORT_LIST)); |
...om/linecorp/centraldogma/server/internal/storage/repository/cache/CachingRepositoryTest.java
Outdated
Show resolved
Hide resolved
ikhoon
reviewed
Jan 22, 2020
| @@ -149,7 +148,7 @@ private static void verifyTwoIndependentCommands(Replica replica, | |||
| Command<?> command1, | |||
| Command<?> command2) { | |||
| final AtomicReference<Command<?>> lastCommand = new AtomicReference<>(); | |||
| verify(replica.delegate, timeout(Duration.ofSeconds(2)).times(1)).apply(argThat(c -> { | |||
| verify(replica.delegate, timeout(TimeUnit.SECONDS.toMillis(2)).times(1)).apply(argThat(c -> { | |||
There was a problem hiding this comment.
Nice 👍
I found timeout(Duration) has been reverted since 3.2.3 due to Android compatibility issue.
mockito/mockito#1843
ikhoon
approved these changes
Jan 22, 2020
trustin
approved these changes
Jan 23, 2020
|
Thanks a lot and sorry I'm late! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates part of unit tests to JUnit 5.
Changes:
ProjectServiceV1Testto reduce the number of Central Dogma instancesZooKeeperCommandExecutorTestassertThat().hasSize()where applicable