feat: update gradle 8.7 and use Java 21 to build armeria #5644

Dogacel · 2024-04-27T04:01:30Z

Motivation:

For some reason my IDE tried to use java-21, however it threw an error! When I looked into it, I realized gradle was kinda a old and decided to do the update.

Modifications:

The command I run to upgrade gradle is gradle wrapper --gradle-version 8.7.

Update gradle wrapper to 8.7
Update CI/CD pipelines to use Java 21
Update Proguard to 7.4+ for Java 21 support

Also did changes regarding the deprecation warnings:

WARNING: The following functionality has been deprecated and will be removed in the next major release of the Develocity Gradle plugin. For assistance with migration, see https://gradle.com/help/gradle-plugin-develocity-migration.
- The deprecated "gradleEnterprise.buildScan.tag" API has been replaced by "develocity.buildScan.tag"
- The deprecated "gradleEnterprise.buildScan.buildFinished" API has been replaced by "develocity.buildScan.buildFinished"
- The deprecated "gradleEnterprise.buildScan.background" API has been replaced by "develocity.buildScan.background"
- The deprecated "gradleEnterprise.server" API has been replaced by "develocity.server"
- The deprecated "gradleEnterprise.buildScan.publishIfAuthenticated" API has been replaced by "develocity.buildScan.publishing.onlyIf { it.authenticated }"
- The deprecated "gradleEnterprise.buildScan.uploadInBackground" API has been replaced by "develocity.buildScan.uploadInBackground"
- The deprecated "gradleEnterprise.buildScan.capture.taskInputFiles" API has been replaced by "develocity.buildScan.capture.fileFingerprints"
- The deprecated "gradleEnterprise.buildCache" API has been replaced by "develocity.buildCache"
- The deprecated "gradleEnterprise.buildScan.value" API has been replaced by "develocity.buildScan.value"
- The deprecated "gradleEnterprise.buildScan.link" API has been replaced by "develocity.buildScan.link"
- The deprecated "predictiveSelection.enabled" API has been replaced by "develocity.predictiveTestSelection.enabled"
- The "com.gradle.enterprise" plugin has been replaced by "com.gradle.develocity"
- The "buildScan.publishAlways" API has been removed, the updated Develocity "buildScan.publishing" API publishes a Build Scan by default

And please update the repository secrets to fix this issue,

The deprecated "GRADLE_ENTERPRISE_ACCESS_KEY" environment variable has been replaced by "DEVELOCITY_ACCESS_KEY"

Result:

Support JDK-21 for building armeria.
Use latest gradle version 8.7.

github-actions · 2024-04-27T04:25:47Z

🔍 Build Scan® (commit: `80b70e3`)

Job name	Status	Build Scan®

Dogacel · 2024-04-27T13:21:14Z

This is why CI is failing 🙂

@Dogacel is not a maintainer. Disallowed to change GitHub Actions workflows.

ikhoon · 2024-04-27T13:31:34Z

We use self-hosted runners for which GitHub does not support Docker environments. An attacker may install malicious code to steal our credentials when GitHub actions jobs using sensitive information are running.

Let us take over this PR. I will create a new branch based on your PR and add you as a co-author.

Dogacel · 2024-04-28T00:16:43Z

We use self-hosted runners for which GitHub does not support Docker environments. An attacker may install malicious code to steal our credentials when GitHub actions jobs using sensitive information are running.

Let us take over this PR. I will create a new branch based on your PR and add you as a co-author.

That's pretty fair 🙂 Thanks for the explanation! Good security measures 👍

Dogacel · 2024-04-28T15:34:34Z

@ikhoon Just letting you know, the existing GitHub runners are successfully building as of yesterday. I had to upgrade ProGuard because 7.3 did not support Java 21. Please LMK if anything comes up.

trustin · 2024-04-30T06:53:26Z

Thanks @Dogacel for trying to keep things up-to-date! 🙇

ikhoon · 2024-05-08T08:26:50Z

settings.gradle

+        capture {
+            fileFingerprints = true
+        }


Why did you manually set this value? It seems the value is enabled by default.
https://docs.gradle.com/develocity/gradle-plugin/api/com/gradle/develocity/agent/gradle/scan/BuildScanCaptureConfiguration.html#getFileFingerprints()

I believe I was migrating the old taskInputFiles parameter and found this one as the replacement. We can remove it if it is no longer needed.

ikhoon · 2024-05-08T08:31:49Z

build.gradle

@@ -370,7 +370,7 @@ class TestsReportTask extends DefaultTask {
 }

 def graalLauncher = javaToolchains.launcherFor {
-    languageVersion.set(JavaLanguageVersion.of(17))
+    languageVersion.set(JavaLanguageVersion.of(rootProject.ext.buildJdkVersion))


Let me revert this change in my local branch because GraalVM does not fully support 21.

FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':installGraalNativeImage'. > A problem occurred starting process 'command '/Users/ikhoon/.gradle/jdks/graalvm_community-21-aarch64-os_x/graalvm-community-openjdk-21.0.2+13.1/Contents/Home/lib/installer/bin/gu''

After checking further, I found that there were changes in GraalVM packaging. lib/svm/bin/rebuild-images and lib/installer/bin/gu do not exist in version 21.
Upgrading GraalVM needs to be handled as a separate issue.

Interesting, I think in that sense graal builds should be optional based on JVM version. Otherwise it gave me an error regarding class version incompatibility.

This might not be a required change, I think I got confused because of the warnings proguard threw. I hope it is gonna build after you revert the changes 👍

@Dogacel

Motivation: As non-maintainer users can't update GitHub workflow files, this PR supersedes @Dogacel's work (line#5644) Modifications: - Use JDK 21 to run Armeria CI and other jobs - Upgrade Gradle version to 8.7 Result: You can now use Java 21 to build Armeria Co-Author: Dogacel <dogacel@gmail.com>

@Dogacel

Motivation: As non-maintainer users can't update GitHub workflow files, this PR supersedes @Dogacel's work (line#5644) Modifications: - Use JDK 21 to run Armeria CI and other jobs - Upgrade Gradle version to 8.7 Result: You can now use Java 21 to build Armeria Co-authored-by: Dogacel <dogacel@gmail.com>

@Dogacel

Motivation: As non-maintainer users can't update GitHub workflow files, this PR supersedes @Dogacel's work (line#5644) Modifications: - Use JDK 21 to run Armeria CI and other jobs - Upgrade Gradle version to 8.7 Result: You can now use Java 21 to build Armeria Co-authored-by: Dogacel <dogacel@gmail.com>

@Dogacel

Motivation: As non-maintainer users can't update GitHub workflow files, this PR supersedes @Dogacel's work (#5644) Modifications: - Use JDK 21 to run Armeria CI and other jobs - Upgrade Gradle wrapper version to 8.7 Result: You can now use Java 21 to build Armeria Co-authored-by: Dogacel <dogacel@gmail.com>

minwoox · 2024-05-17T05:44:22Z

Superseded by #5667

feat: update gradle 8.7 and use Java 21 to build armeria

ff73f58

Dogacel added 2 commits April 27, 2024 19:28

attempt to fix graal

39b64d3

pro guard 7.4.2

259ee6b

Merge branch 'main' into dogac/update-gradle-8.7

b86dd96

Dogacel requested review from ikhoon, jrhee17, minwoox and trustin as code owners April 30, 2024 03:11

Merge branch 'main' into dogac/update-gradle-8.7

80b70e3

ikhoon reviewed May 8, 2024

View reviewed changes

ikhoon mentioned this pull request May 8, 2024

Use Java 21 to build Armeria (+Gradle 8.7 wrapper) #5667

Merged

minwoox closed this May 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update gradle 8.7 and use Java 21 to build armeria #5644

feat: update gradle 8.7 and use Java 21 to build armeria #5644

Dogacel commented Apr 27, 2024 •

edited

github-actions bot commented Apr 27, 2024 •

edited

Dogacel commented Apr 27, 2024

ikhoon commented Apr 27, 2024

Dogacel commented Apr 28, 2024

Dogacel commented Apr 28, 2024 •

edited

trustin commented Apr 30, 2024

ikhoon May 8, 2024

Dogacel May 8, 2024

ikhoon May 8, 2024

ikhoon May 8, 2024 •

edited

Dogacel May 8, 2024

Dogacel May 8, 2024

minwoox commented May 17, 2024

feat: update gradle 8.7 and use Java 21 to build armeria #5644

feat: update gradle 8.7 and use Java 21 to build armeria #5644

Conversation

Dogacel commented Apr 27, 2024 • edited

github-actions bot commented Apr 27, 2024 • edited

🔍 Build Scan® (commit: 80b70e3)

Dogacel commented Apr 27, 2024

ikhoon commented Apr 27, 2024

Dogacel commented Apr 28, 2024

Dogacel commented Apr 28, 2024 • edited

trustin commented Apr 30, 2024

ikhoon May 8, 2024

Choose a reason for hiding this comment

Dogacel May 8, 2024

Choose a reason for hiding this comment

ikhoon May 8, 2024

Choose a reason for hiding this comment

ikhoon May 8, 2024 • edited

Choose a reason for hiding this comment

Dogacel May 8, 2024

Choose a reason for hiding this comment

Dogacel May 8, 2024

Choose a reason for hiding this comment

minwoox commented May 17, 2024

Dogacel commented Apr 27, 2024 •

edited

github-actions bot commented Apr 27, 2024 •

edited

🔍 Build Scan® (commit: `80b70e3`)

Dogacel commented Apr 28, 2024 •

edited

ikhoon May 8, 2024 •

edited