Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record causes of failed attempts for RetryingClient #5583

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

my4-dev
Copy link
Contributor

@my4-dev my4-dev commented Apr 8, 2024

Motivation:
#5283

Modifications:

  • Separating onResponse into onResponseOnClient and onResponseOnServer as refactoring
  • Add failureAttempts(Throwable error) and failureAttempts(HttpStatus httpstatus) at ClientRequestMetrics and make us enable to record causes of failed attempts

Result:

"actual.requests.attempts.errors{result=failure, cause=ResponseTimeoutException}=NN"

Previous PR:
#5405

@github-actions github-actions bot added the Stale label May 9, 2024
@minwoox minwoox added this to the 1.29.0 milestone May 21, 2024
@minwoox minwoox added new feature and removed Stale labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record causes of failed attempts for RetryingClient
2 participants