Update frontend and site dependencies #4126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4126 +/- ##
============================================
- Coverage 73.22% 73.22% -0.01%
+ Complexity 16137 16136 -1
============================================
Files 1405 1405
Lines 61673 61673
Branches 7766 7766
============================================
- Hits 45161 45160 -1
- Misses 12583 12590 +7
+ Partials 3929 3923 -6
Continue to review full report at Codecov.
|
|
Oops, could you check the build failure in Windows OS? |
| "license-webpack-plugin": "^2.3.18", | ||
| "prettier": "^2.2.1", | ||
| "html-webpack-plugin": "^5.5.0", | ||
| "license-webpack-plugin": "^4.0.2", |
There was a problem hiding this comment.
The new license-webpack-plugin adds a warning layer on top of a page.
That might be an unintentional change. We can turn off the warning by setting stats.warning: false.
But I could not find a way to only turn off the warning on the screen.
There was a problem hiding this comment.
I have no idea, either. What are we supposed to do, then?
There was a problem hiding this comment.
I found that it is not a breaking change in license-webpack-plugin.
It is a new feature of webpack-dev-server.
webpack/webpack-dev-server#3689 (comment)
We can remove the overlay with:
devServer: {
client: {
overlay: false
// OR
overlay: {
warnings: false,
errors: true
}
}
}
Modifications: - Updated most frontend and site dependencies to their latest versions, except those that need non-trivial migration: - MUI - Gatsby (Updated from v2 to v3, but not to v4) - Fixed all newly reported ESLint violations, except those that don't make much sense. - Updated the `eslintrc.js` accordingly. - Merged `steps.module.less` into `antd-overrides.less` because it doesn't contain any component-specific styles. - Worked around the problem where the CSS class names of Table of Contents contain a plus (+) sign, preventing `tocbot` from working correctly. - Updated `gatsby-remark-draw-patched.js` so it embeds the SVG images rather than writing to an external file, because Gatsby doesn't handle them correcly anymore. - Forked the SVGBob rendering code from skyrta because `svgbob` command has been renamed to `svgbob_cli` some time ago. Result: - 0 vulnerability in `docs-client` - Less vulnerabilities in `site` - A contributor can build `site` from macOS on aarch64 (M1)
trustin
force-pushed
the
update_frontend_deps
branch
from
d2d082d
to
2a4e8f0
Compare
I set up the dev environment on Windows and it seems like there's a bug somewhere between Webpack and license-webpack-plugin. I disabled the plugin when running on Windows for now given that we never release on Windows. |
Modifications:
except those that need non-trivial migration:
make much sense.
eslintrc.jsaccordingly.steps.module.lessintoantd-overrides.lessbecause itdoesn't contain any component-specific styles.
Contents contain a plus (+) sign, preventing
tocbotfrom workingcorrectly.
gatsby-remark-draw-patched.jsso it embeds the SVG imagesrather than writing to external files, because Gatsby doesn't handle
them correcly anymore.
skyrtabecausesvgbobcommandhas been renamed to
svgbob_clisome time ago.license-webpack-pluginon Windows due to a known issue.Result:
docs-clientsitesitefrom macOS on aarch64 (M1)