Fix content corruption in a chunked response on HTTP/1 over TLS #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There's a chance of HTTP content corruption when: - The current connection is TLS; - The current response is using chunked encoding; and - The content length is greater than 16378 (16384 - 6). .. due to a bug in Netty: netty/netty#11792 Modifications: - Fixed the math mistake in `Http1ObjectEncoder.MAX_TLS_DATA_LENGTH`, to prevent `HttpObjectEncoder` from putting its static final `ByteBuf` in the first place of `SslHandler`'s internal queue. Result: - No more HTTP content conrruption.
trustin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3894 +/- ##
============================================
+ Coverage 73.26% 73.27% +0.01%
- Complexity 15528 15529 +1
============================================
Files 1365 1365
Lines 59831 59831
Branches 7582 7582
============================================
+ Hits 43833 43839 +6
+ Misses 12151 12145 -6
Partials 3847 3847
Continue to review full report at Codecov.
|
trustin
commented
Oct 26, 2021
| if (cause != null) { | ||
| caughtExceptions.add(cause); | ||
| } | ||
| try { |
There was a problem hiding this comment.
This has to be guarded by an else block. Let me push a fix commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There's a chance of HTTP content corruption when:
.. due to a bug in Netty: netty/netty#11792
Modifications:
Http1ObjectEncoder.MAX_TLS_DATA_LENGTH,to prevent
HttpObjectEncoderfrom putting its static finalByteBufin the first place of
SslHandler's internal queue.Result: