Skip to content

Commit

Permalink
vendor packaging.version for our own use
Browse files Browse the repository at this point in the history
because LegacyVersion is deprecated.
closes #180.
  • Loading branch information
lilydjwg committed Jul 18, 2021
1 parent 151b038 commit 606b3f6
Show file tree
Hide file tree
Showing 4 changed files with 636 additions and 6 deletions.
5 changes: 4 additions & 1 deletion nvchecker/lib/README.md
@@ -1 +1,4 @@
This directory contains modules from my [winterpy](https://github.com/lilydjwg/winterpy).
This directory contains code from other places:

* `nicelogger.py`: from my [winterpy](https://github.com/lilydjwg/winterpy)
* `packaging_version.py`: from python-packaging 20.9, modified
3 changes: 0 additions & 3 deletions nvchecker/lib/__init__.py
@@ -1,3 +0,0 @@
# MIT licensed
# Copyright (c) 2020 lilydjwg <lilydjwg@gmail.com>, et al.

2 comments on commit 606b3f6

@yan12125
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you also update docs/usage.rst? That file mentions pkg_resource.parse_version, while after the removal of LegacyVersion [1], the behavior of that function will be different from the one in nvchecker.

[1] pypa/packaging#407

@lilydjwg
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated that so people know there are no longer the same.

Please sign in to comment.