Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Loader] [Data Locator] [Dependency Injection] Pass root paths to FileSystemLocator during construction #930

Merged
merged 5 commits into from Mar 2, 2018
Merged

[Data Loader] [Data Locator] [Dependency Injection] Pass root paths to FileSystemLocator during construction #930

merged 5 commits into from Mar 2, 2018

Commits on Mar 2, 2018

  1. Require fully instantiated Locator in FileSystemLoader

    @rpkamp @robfrawley
    rpkamp authored and robfrawley committed Mar 2, 2018
    Copy the full SHA
    5626282 View commit details
    Browse the repository at this point in the history

  2. Add test to ensure to separate loaders can be created with their own … 

    …datapaths
    @rpkamp @robfrawley
    rpkamp authored and robfrawley committed Mar 2, 2018
    Copy the full SHA
    7965bb8 View commit details
    Browse the repository at this point in the history

  3. Remove no longer needed use statements

    @rpkamp @robfrawley
    rpkamp authored and robfrawley committed Mar 2, 2018
    Copy the full SHA
    f44a254 View commit details
    Browse the repository at this point in the history

  4. run php-cs-fixer using latest rules

    @robfrawley
    robfrawley committed Mar 2, 2018
    Copy the full SHA
    567a228 View commit details
    Browse the repository at this point in the history

  5. add types to locator interface/class method signiture(s)

    @robfrawley
    robfrawley committed Mar 2, 2018
    Copy the full SHA
    485ea32 View commit details
    Browse the repository at this point in the history