Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Flysystem 3.0 #1445

Merged
merged 1 commit into from Jan 14, 2022
Merged

Allow Flysystem 3.0 #1445

merged 1 commit into from Jan 14, 2022

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jan 14, 2022

Q A
Branch? 2.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets N/A
License MIT
Doc N/A

Flysystem 3.0 has been released. The only B/C breaks in the new major are a raised PHP minimum and a couple of added methods on the core interfaces, so based on a quick scan through the bundle code, all of the existing logic to support Flysystem 2.x will transparently keep working.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.406% when pulling 99293d7 on mbabker:patch-1 into e53f36d on liip:2.x.

@mbabker
Copy link
Contributor Author

mbabker commented Jan 14, 2022

The code style CI failure is unrelated to this PR, I only changed the composer.json file!

Based on PHP-CS-Fixer/PHP-CS-Fixer#6240 at least one of the errors in that build is related to their 3.5.0 release.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. yeah as we don't implement the flysystem interfaces but are only consumer, this should be a trivial upgrade.

@dbu dbu merged commit f93083e into liip:2.x Jan 14, 2022
@mbabker mbabker deleted the patch-1 branch January 14, 2022 16:44
@dbu
Copy link
Member

dbu commented Jan 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants