Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] [Controller] Add controller redirect response code configuration option #1220

Conversation

franmomu
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #970 #1101
License MIT
Doc PR

Rebased version of #1101

@franmomu franmomu force-pushed the feature-add-controller-config-redirect-response-code branch 2 times, most recently from 698b011 to 2d8bddd Compare August 30, 2019 22:27
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, you had a busy weekend 👍

again some comments by me ;-)

Resources/config/imagine.xml Outdated Show resolved Hide resolved
Config/Controller/ControllerConfig.php Outdated Show resolved Hide resolved
Resources/config/imagine.xml Outdated Show resolved Hide resolved
@franmomu franmomu force-pushed the feature-add-controller-config-redirect-response-code branch 6 times, most recently from 9b9bce1 to 51b1429 Compare September 3, 2019 20:13
Signed-off-by: Rob Frawley 2nd <rmf@src.run>
@franmomu franmomu force-pushed the feature-add-controller-config-redirect-response-code branch from 51b1429 to d61e294 Compare September 3, 2019 20:22
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants