New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filters] [Config] [DI] Add Filter configuration class as public service #1098
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6b41c3b
added FilterSetCollection public service
maximgubar 11c0c12
fixed static tests
maximgubar 6a8cff3
removed setters from Filters and FilterSets
maximgubar add533f
fixed static tests
maximgubar 95db82b
added filter-specific objects
maximgubar d907670
fixed static tests
maximgubar e213124
applied requested review changes
maximgubar 851a38b
fixed static tests
maximgubar 27c8794
removed FilterConfiguration object dependency
maximgubar 5c4d68f
renamed FilterSet to Stack
maximgubar e306612
added filters config objects
maximgubar db0a518
added filters config objects
maximgubar d6c599f
fixed static tests
maximgubar 6906000
added optional return types, removed unnecessary phpdocs
maximgubar 4ea4acc
added Point and Size objects
maximgubar ebc5744
replaced trivial ternary operations with null coalesce operator
maximgubar 02e4022
applied PR fixes
maximgubar c4923d0
added @internal to all config-related factories
maximgubar c564a62
introduced StckFactoryInterface
maximgubar 9971029
moved filter NAME const from factory to instance
maximgubar 36d7843
fixed static tests
maximgubar 91bfe94
applied PR fixes
maximgubar 9df4d4b
added @codeCoverageIgnore
maximgubar be890e3
applied PR fixes
maximgubar 8458b37
renamed filterSet to stack
maximgubar 6613b61
removed self-referencing constant
maximgubar cdab3b8
fixed static tests
maximgubar f8cdfb7
fixed small issues:
maximgubar 2a397ae
fixed Watermark factory arguments order and type sanitize
maximgubar f1ed641
Merge branch '2.0' into config-reader
maximgubar 0624a2a
removed backslashes from native constants
maximgubar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use value objects/enum here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Koc for all parameters or for specific one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would not use value objects here. if the imagine library would use them, we should use them here too, but as they don't i feel like its a bit too much.