[TEST]: ImagineController functional test fixes

[nmuntyanov]

Q	A
Branch?	2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

It seems that Symfony\Component\BrowserKit\Client library was updated and since that
Symfony\Component\BrowserKit\Client::request() doesn't throws server's exceptions.
So, my fix is to check responses status codes instead checking for exceptions

[maximgubar]

@nmuntyanov, there are failed builds on CI for your PR. could you please fix it ?

[maximgubar]

and could you please provide a test-case on how to reproduce this issue ?

[nmuntyanov]

@maximgubar All that I was able to reproduce on my local environment was fixed by me in this PR.
The issue was inside the tests: because of that there is no composer.lock file - new Symfony component was installed (symfony/browser-kit I guess) and it has no backward compatibility.

[robfrawley]

it has no backward compatibility

@nmuntyanov That isn't true, or if it is then Symfony has a bug that needs to be corrected (as there should be no breaking changes between the 4.0.0 release and the following 4.x.x releases. You need to test locally using multiple versions of Symfony, including dev-master, as our CI does.

That said, I suggest you rebase on top of the latest 2.0 branch (bringing in the changes merged in #1090) which should fix at least one of the failures I saw for your PR (I'm not sure about the other one though).

Note: please be sure to rebase and not merge when applying your changes on top of the current repo upstream.

[robfrawley]

Oops, nevermind my prior comment. #1090 was the same fix you are attempting to fix here, but there was a way to accomplish it without removing our expected exceptions. Thanks though for you involvment in this project!

(Specifically, https://github.com/liip/LiipImagineBundle/pull/1090/files#diff-8ddc477a77a8b3fdbab01fd8e6231b95R47 fixed the issue you have here without editing the tests; see symfony/symfony#22890)