WebTestCase memory leak fix #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please fix the issue reported by StyleCI. |
|
@shtumi could you please rebase the PR and fix the error reported by StyleCI? |
|
really currently code of WebTestCase is changed a lot and I'm really not sure that problem is still exists and if exists, then then it's more easy to take new fork, investigate the problem and give new solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is memory leak in WebTestCase because method getContainer creates new kernel which is never shutdown.
So in my project I was need more then 4Gb of memory to pass about 800 tests.
After fix I need less then 300Mb.
This problem was discussed here:
symfony/symfony#35164
And also it was fixed in similar (but not exact) way inside LiipTestFixturesBundle:
liip/LiipTestFixturesBundle#62