Skip to content

Commit

Permalink
Make some class finals
Browse files Browse the repository at this point in the history
I did not set final on the `Liip\FunctionalTestBundle\Services\DatabaseTools` because we already extends ORM for Sqlite so it feels like user can need it too ?

Fixes #380
  • Loading branch information
magnetik committed Jul 17, 2018
1 parent 15e82b4 commit 294f812
Show file tree
Hide file tree
Showing 11 changed files with 10 additions and 19 deletions.
2 changes: 1 addition & 1 deletion src/Annotations/QueryCount.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* @Annotation
* @Target({"METHOD"})
*/
class QueryCount
final class QueryCount
{
/** @var int */
public $maxQueries;
Expand Down
2 changes: 1 addition & 1 deletion src/EventListener/ExceptionListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\KernelEvents;

class ExceptionListener implements EventSubscriberInterface
final class ExceptionListener implements EventSubscriberInterface
{
/**
* @var \Exception|null
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/AllowedQueriesExceededException.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@

namespace Liip\FunctionalTestBundle\Exception;

class AllowedQueriesExceededException extends \Exception
final class AllowedQueriesExceededException extends \Exception
{
}
2 changes: 1 addition & 1 deletion src/QueryCounter.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Liip\FunctionalTestBundle\Annotations\QueryCount;
use Liip\FunctionalTestBundle\Exception\AllowedQueriesExceededException;

class QueryCounter
final class QueryCounter
{
/** @var int */
private $defaultMaxCount;
Expand Down
2 changes: 1 addition & 1 deletion src/Services/DatabaseBackup/MongodbDatabaseBackup.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @author Aleksey Tupichenkov <alekseytupichenkov@gmail.com>
*/
class MongodbDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
final class MongodbDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
{
protected static $referenceData;

Expand Down
2 changes: 1 addition & 1 deletion src/Services/DatabaseBackup/MysqlDatabaseBackup.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Aleksey Tupichenkov <alekseytupichenkov@gmail.com>
*/
class MysqlDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
final class MysqlDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
{
protected static $referenceData;

Expand Down
2 changes: 1 addition & 1 deletion src/Services/DatabaseBackup/SqliteDatabaseBackup.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Aleksey Tupichenkov <alekseytupichenkov@gmail.com>
*/
class SqliteDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
final class SqliteDatabaseBackup extends AbstractDatabaseBackup implements DatabaseBackupInterface
{
public function getBackupFilePath(): string
{
Expand Down
2 changes: 1 addition & 1 deletion src/Services/DatabaseToolCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* @author Aleksey Tupichenkov <alekseytupichenkov@gmail.com>
*/
class DatabaseToolCollection
final class DatabaseToolCollection
{
private $container;

Expand Down
2 changes: 1 addition & 1 deletion src/Services/FixturesLoaderFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Aleksey Tupichenkov <alekseytupichenkov@gmail.com>
*/
class FixturesLoaderFactory
final class FixturesLoaderFactory
{
private $container;

Expand Down
2 changes: 1 addition & 1 deletion src/Services/SymfonyFixturesLoaderWrapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Doctrine\Bundle\FixturesBundle\Loader\SymfonyFixturesLoader;
use Doctrine\Common\DataFixtures\Loader;

class SymfonyFixturesLoaderWrapper extends Loader
final class SymfonyFixturesLoaderWrapper extends Loader
{
private $symfonyFixturesLoader;

Expand Down
9 changes: 0 additions & 9 deletions tests/App/AppKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@

namespace Liip\FunctionalTestBundle\Tests\App;

/*
* This file is part of the Liip/FunctionalTestBundle
*
* (c) Lukas Kahwe Smith <smith@pooteeweet.org>
*
* This source file is subject to the MIT license that is bundled
* with this source code in the file LICENSE.
*/

use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel;
Expand Down

0 comments on commit 294f812

Please sign in to comment.