Instrument obsreport.Processor #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not none Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
…metry#6426) Fixes open-telemetry#6191, open-telemetry#6197, open-telemetry#6198 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Extending feature gates to include reference URL and removal version.
Update values returned by all String methods of enum types to a consistent short form representing the enum identifier
These were requiring an invalid version of the collector (which was overwritten via replace statements in the module) but causes any modules that include them to require the invalid version of the collector.
fixes open-telemetry#6389 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
…or of `obsreport.MustNew*` (open-telemetry#6464)
moh-osman3
changed the title
…ess (open-telemetry#6421) Unrevert open-telemetry#6267 and make it so that we never error out. Co-authored-by: Alex Boten <alex@boten.ca>
…pen-telemetry#6466) Signed-off-by: Bogdan <bogdandrutu@gmail.com>
This updates the dependency for the batch processor in go.mod to make updating contrib easier.
Extended the documentation of the component to include safe Shutdown expectations. Co-authored-by: Alex Boten <alex@boten.ca>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…pen-telemetry#6531) This change updates values returned by `StabilityLevel.String` to be consistent with other enum types: - All returned strings are capitalized. - "Undefined" is returned only for `StabilityLevelUndefined`. - "" is returned for integers that are out of StabilityLevel enum range.
@dmitryax has done an enormous amount of work on stabilizing the core APIs. He is the next most active contributor to this repository and I think he will be a great maintainer.
This is part of open-telemetry#6186 Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
- Instrument batch processor with OpenTelemetry Go. - Also fixed a small typo on the bucket definition of the batch_send_size_bytes view of OpenCensus.
Signed-off-by: Alex Boten <aboten@lightstep.com>
…line (open-telemetry#6540) * [pipelines] Change test to not reuse same processor twice in one pipeline * Add note to documentation about reuse of processors within a pipeline * can -> MUST
This specifically calls out the correct way to merge the pull request.
…ge (open-telemetry#6532) This was something the I missed during the previous review. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Fixes open-telemetry#6526 Signed-off-by: Alex Boten <aboten@lightstep.com>
…n-telemetry#6572) * Deprecate Config.Validate() in favor of component.ValidateConfig This PR is "split" from open-telemetry#6544, to avoid breaking changes and go via deprecation. It is a bit hacky, but better than breaking everyone who uses this interface. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update config/receiver.go Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
…metry#6575) Signed-off-by: Alex Boten <aboten@lightstep.com> Signed-off-by: Alex Boten <aboten@lightstep.com>
* Instrument obsreport.Scraper (#19) * instrument obsreport.scraper metrics with otel go * add changelog * update API to use MustNewScraper * fix typo add testing for checkScraperMetrics * remove accidental merge conflict references * fix references after rebase * address review comments * remove unneded log * add newlines * run gofmt * fix indenting
…ckage (open-telemetry#6553) * Draft minimum changes to component.Host Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update .chloggen/draftminhost.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
…type. (open-telemetry#6579) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
moh-osman3
force-pushed
the
mohosman/instrument-processor
branch
from
7008963
to
63217f1
Compare
|
Opened new branch and cherry picked commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR instruments obsreport.Processor with otel go. This is a followup PR that is based on similar changes made for obsreport.Receiver: open-telemetry#6222
Link to tracking Issue: Part of open-telemetry#816
Testing:
Ran contrib collector with memory_limiter processor and prometheusreceiver + sent traces from demo client and confirmed that new metrics show up. Tested both with feature gate disabled and enabled.
From output of
$ curl localhost:8888/metrics