put otel meter for http/grpc behind a FF #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // EnableHighCardinalityMetricsfeatureGate is the feature gate that controls whether the collecor should enable | ||
| // potentially high cardinality metrics. | ||
| var EnableHighCardinalityMetricsfeatureGate = featuregate.GlobalRegistry().MustRegister( | ||
| "telemetry.enableHighCardinalityMetrics", |
There was a problem hiding this comment.
What about renaming this as "enableRPCMetrics" or something like that, to be more specific about what this is gating?
There was a problem hiding this comment.
this was coming from the issue i opened against the collector open-telemetry#7517 (comment) given there may be some more high cardinality metrics like this in the future.
paivagustavo
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the high cardinality stuff behind an FF