Instrument exporters #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obsreport/obsreport_exporter.go
Outdated
| @@ -16,6 +16,13 @@ package obsreport // import "go.opentelemetry.io/collector/obsreport" | |||
|
|
|||
| import ( | |||
| "context" | |||
| "go.opentelemetry.io/collector/featuregate" | |||
There was a problem hiding this comment.
make sure this is formatted correctly,
paivagustavo
approved these changes
Oct 18, 2022
jaronoff97
added a commit
that referenced
this pull request
Oct 18, 2022
* Allow for dual instrumentation * remove log * Add back mutators
moh-osman3
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Allow for dual instrumentation * remove log * Add back mutators
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* Allow for dual instrumentation * remove log * Add back mutators
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* Allow for dual instrumentation * remove log * Add back mutators
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* Allow for dual instrumentation * remove log * Add back mutators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds OpenTelemetry instrumentation for the obsreport exporter. This closely follows the previous PR from @paivagustavo for the receiver (seen here)
Link to tracking Issue: Part of open-telemetry#816
Testing: This was tested by running the otel collector locally with the demo client and server. It successfully ran with the gate enabled and disabled, emitting the same metrics.