Remove ErrSynchronizingChain #7039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Crypt-iQ: review reminder |
Crypt-iQ
approved these changes
Oct 25, 2022
yyforyongyu
reviewed
Oct 27, 2022
TonyGiorgio
force-pushed
the
sync-7034
branch
from
4ddc773
to
5bc7969
Compare
|
Rebased. Let me know if there's any errors to fix. I noticed the CI hasn't been healthy for awhile so I can't tell if there's something I need to fix. |
yyforyongyu
reviewed
Oct 28, 2022
TonyGiorgio
force-pushed
the
sync-7034
branch
from
5bc7969
to
0953759
Compare
|
I think that should do it, let me know if the release note comment should be any different. |
guggero
reviewed
Oct 28, 2022
| // ErrChanTooLarge is returned by a remote peer that receives a | ||
| // FundingOpen request for a channel that is above their current | ||
| // soft-limit. | ||
| ErrChanTooLarge FundingError = 3 | ||
| ErrChanTooLarge FundingError = 2 |
There was a problem hiding this comment.
@Crypt-iQ so even though this is declared in the lnwire package, this constant is never used on the wire? So changing the number shouldn't have any side effects? I guess we only created the type for internal handling then...
There was a problem hiding this comment.
yes its not used on the wire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This fixes #7034 where an LND node reveals that is it vulnerable to chain tip sync problems such as #7002, which may be exploited by those with existing channels with the node by broadcasting a previous channel state. It would be better if other actors do not know if a node is synced or not.
Steps to Test
funding failed due to internal error)