Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CI build with 1.63.0 as MSRV #19

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Check CI build with 1.63.0 as MSRV #19

wants to merge 1 commit into from

Conversation

G8XSU
Copy link
Collaborator

@G8XSU G8XSU commented Nov 28, 2023 •
edited

Closes #4

@G8XSU G8XSU marked this pull request as draft December 4, 2023 20:38
tnull
tnull reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you'll need to pin at least regex in CI, possibly some other dependencies, too.

See https://github.com/lightningdevkit/rust-lightning/blob/3751398518cb5c9b26a596c0dc9b33571abcf756/ci/ci-tests.sh#L60-L61.

@tnull
Copy link
Contributor

tnull commented Feb 12, 2024

Would be good to move forward with this since we're about to add additional dependencies which need to comply with our MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start enforcing some(MSRV)
2 participants
@G8XSU @tnull