Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Deref for EmptyNodeIdLookUp #3058

Merged

Conversation

benthecarman
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.79%. Comparing base (38690bf) to head (bfff6fd).
Report is 4 commits behind head on main.

Files Patch % Lines
lightning/src/blinded_path/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3058      +/-   ##
==========================================
- Coverage   89.85%   89.79%   -0.06%     
==========================================
  Files         116      116              
  Lines       96303    96293      -10     
  Branches    96303    96293      -10     
==========================================
- Hits        86529    86465      -64     
- Misses       7217     7261      +44     
- Partials     2557     2567      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, trivial deref similar to what we offer for IgnoringMessageHandler and the like, merging.

@TheBlueMatt TheBlueMatt merged commit 1890e80 into lightningdevkit:main May 13, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants