Add unsafe_funding_transaction_generated
#3056
Conversation
..under `ChannelManager`. It replicates the functionality of the original `funding_transaction_generated` in the same module but without checking if the witness data is set in the funding transction inputs.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 89.84% 89.83% -0.01%
==========================================
Files 116 116
Lines 96303 96367 +64
Branches 96303 96367 +64
==========================================
+ Hits 86521 86573 +52
- Misses 7225 7232 +7
- Partials 2557 2562 +5 ☔ View full report in Codecov by Sentry. |
|
@TheBlueMatt while working on this I noticed the |
| /// channel (note that this should be trivially prevented by using unique funding transaction | ||
| /// keys per-channel). | ||
| /// | ||
| /// Do NOT broadcast the funding transaction yourself. When we have safely received our |
There was a problem hiding this comment.
Oops, sorry for the confusion, my comment at #3024 (comment) wasn't really intended to be that we'd expect users to handle this crazy hacky indirection, but rather we could push the broadcast out via the Event described in that PR but just don't use a config knob and rather do it via a new channel funding method.
There was a problem hiding this comment.
the goal of this pr is to introduce an "unsafe_funding_tx_generated" that wouldnt check if the witness data is empty (https://github.com/lightningdevkit/rust-lightning/pull/3056/files?diff=split&w=0#diff-645d12c7269d09caab57d2e0c1fd34f672ee259994c86ad4bad7f4da9183671cR4682) but call batch_funding_transaction_generated_intern directly.
is it the only blocker for lightningdevkit/ldk-node#257.
Beside the top lines regarding unsafe, the docs are the same as the original funding_tx_generated.
I see how both PRs are related and introduce two separate functions(which is fine as is) but could be used in the same scenario(ie payjoin) but I would like to get this one merged first and unblock the ldk-node pr and complete the funding signed pr afterwards if that makes sense..
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmmm, it seems a bit weird to introduce this here and then rewrite it one PR later to do something totally different? ISTM we could land #3024 without it taking toooo long.
..under
ChannelManager. It replicates the functionality of the originalfunding_transaction_generatedin the same module but without checking if the witness data is set in the funding transction inputs.#3022