Final backports for 0.0.123 #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added the additional deust exposure checks in 702196819e6445048b803574fcacef77d5ce8c9c we added several additional feerate fetches which broke the `full_stack_target` change-detection test. This updates the hard-coded test to support the new feerate fetches and also includes a comment on `FeeEstimator` to indicate that users really need to be caching feerates as otherwise they'll slow us down.
When parsing lightning-invoice HRPs we want to read them char-by-char, tracking at which offset different fields were. Prior to this commit this was done first by reading char-by-char and then by indexing using the byte offset which works for ASCII strings but fails on multi-byte characters. This commit fixes this issue by simply always walking byte-by-byte and rejecting multi-byte characters which don't belong in HRPs.
|
Will include the release notes here as well when they land. |
I'd uploaded `possiblyrandom` 0.1 to reserve the crate name but with a dummy library so now we need ot use 0.2 for the release.
TheBlueMatt
force-pushed
the
2024-05-123-backports-2
branch
from
ff85414
to
fba4eef
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 0.0.123 #3055 +/- ##
===========================================
+ Coverage 89.82% 89.84% +0.02%
===========================================
Files 116 116
Lines 96425 96428 +3
Branches 96425 96428 +3
===========================================
+ Hits 86609 86636 +27
+ Misses 7244 7222 -22
+ Partials 2572 2570 -2 ☔ View full report in Codecov by Sentry. |
jkczyz
approved these changes
May 8, 2024
|
Oops, forgot to actually update the Cargo.toml versions, fixed. |
valentinewallace
approved these changes
May 8, 2024
jkczyz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3054's fix and the fuzz fix from #3046