Don't attempt to resume channels if we already exchanged funding #3051
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
- Coverage 89.88% 89.80% -0.08%
==========================================
Files 117 117
Lines 96958 96993 +35
Branches 96958 96993 +35
==========================================
- Hits 87146 87106 -40
- Misses 7268 7323 +55
- Partials 2544 2564 +20 ☔ View full report in Codecov by Sentry. |
shaavan
approved these changes
May 8, 2024
|
Fuzz is failing. Otherwise this is the same as #3034 so should be able to Just Land. |
ddf75af introduced the ability to re-exchange our `ChannelOpen` after a peer disconnects if we didn't complete funding on our end. It did not implement nor consider what would happen if we re-connected after we created our own funding transactions, and currently it panics (and even if it did not it would replay the `FundingTransactionGenerated` event to users). While we'd very much like to replay the `open_channel` flow even if we have already received an `accept_channel` and funded the channel, we cannot as the peer will likely provide different key material in their `accept_channel`, causing us to need a different funding transaction. Thus, here, we simply close channels which have been funded but not yet signed when our peer disconnects.
TheBlueMatt
force-pushed
the
2024-04-2982-123-fix
branch
from
eadacaa
to
53cd31a
Compare
|
Just needed a rebase. |
valentinewallace
approved these changes
May 28, 2024
|
Its just one commit already in a release, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddf75af introduced the ability to re-exchange our
ChannelOpenafter a peer disconnects if we didn't complete funding on our end. It did not implement nor consider what would happen if we re-connected after we created our own funding transactions, and currently it panics (and even if it did not it would replay theFundingTransactionGeneratedevent to users).While we'd very much like to replay the
open_channelflow even if we have already received anaccept_channeland funded the channel, we cannot as the peer will likely provide different key material in theiraccept_channel, causing us to need a different funding transaction.Thus, here, we simply close channels which have been funded but not yet signed when our peer disconnects.
Replaces #2983 (comment)
Note that this is the same as the version we already landed for 0.0.123, but I was hoping we could do more, but sadly @shaavan pointed out we cannot.