Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-ups to #2970 #3028

Merged
merged 4 commits into from
Apr 29, 2024

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    d690072 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Remove PaymentContext from OnionPayload

    PaymentContext is already stored in ClaimablePayment via PaymentPurpose,
    so there is no need to repeat it in each ClaimableHTLC via OnionPayload.
    This avoids cloning the PaymentContext each time an HTLC is received,
    other than for the first HTLC for a payment.
    jkczyz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8e562be View commit details
    Browse the repository at this point in the history
  2. Remove InvoiceRequestFields::amount_msats

    Event::PaymentClaimable and Event::PaymentClaimed already contain the
    paid amount, so there's no need to included the requested amount in
    InvoiceRequestFields.
    jkczyz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7b86442 View commit details
    Browse the repository at this point in the history
  3. Remove InvoiceRequestFields::features

    InvoiceRequestFeatures may contain a large, odd bit. Including this in
    InvoiceRequestFields, which is in each BlindedPath of a Bolt12Invoice,
    could cause the invoice's onion message to exceed the maximum size. The
    features are already checked before sending an invoice.
    jkczyz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    33b6162 View commit details
    Browse the repository at this point in the history