-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional description for Offer
and Refund
#3018
Optional description for Offer
and Refund
#3018
Commits on Apr 26, 2024
-
Optional OfferContents::signing_pubkey
If an Offer contains a path, the blinded_node_id of the path's final hop can be used as the signing pubkey. Make Offer::signing_pubkey and OfferContents::signing_pubkey return an Option to support this. Upcoming commits will implement this behavior.
Configuration menu - View commit details
-
Copy full SHA for 520fecf - Browse repository at this point
Copy the full SHA 520fecfView commit details -
Allow parsing Offer without signing_pubkey
If an offer has at least one path, it may omit the signing pubkey and use the blinded node id of the last hop of a path to sign an invoice. Allow parsing such offers but not yet creating them.
Configuration menu - View commit details
-
Copy full SHA for 94d5af6 - Browse repository at this point
Copy the full SHA 94d5af6View commit details -
Add InvoiceRequestTlvStream::paths
Instead of reusing OfferTlvStream::paths, add a dedicated paths TLV to InvoiceRequestTlvStream such that it can be used in Refund. This allows for an Offer without a signing_pubkey and still be able to differentiate whether an invoice is for an offer or a refund.
Configuration menu - View commit details
-
Copy full SHA for 61e4fce - Browse repository at this point
Copy the full SHA 61e4fceView commit details -
Bolt12Invoice for Offer without signing_pubkey
When parsing a Bolt12Invoice use both the Offer's signing_pubkey and paths to determine if it is for an Offer or a Refund. Previously, an Offer was required to have a signing_pubkey. But now that it is optional, the Offers paths can be used to make the determination. Additionally, check that the invoice matches one of the blinded node ids from the paths' last hops.
Configuration menu - View commit details
-
Copy full SHA for b7635c4 - Browse repository at this point
Copy the full SHA b7635c4View commit details -
Don't require Offer::description in API
Offers currently require a description, though this may change to be optional. Remove the description requirement from the API, setting and empty string by default.
Configuration menu - View commit details
-
Copy full SHA for 48cba29 - Browse repository at this point
Copy the full SHA 48cba29View commit details -
Don't require Refund::description in API
Refunds currently require a description, though this may change to be optional. Remove the description requirement from the API, setting and empty string by default.
Configuration menu - View commit details
-
Copy full SHA for db7e696 - Browse repository at this point
Copy the full SHA db7e696View commit details
Commits on May 2, 2024
-
Only require description when offer has an amount
The spec was changed to allow excluding an offer description if the offer doesn't have an amount. However, it is still required when the amount is set.
Configuration menu - View commit details
-
Copy full SHA for e61001f - Browse repository at this point
Copy the full SHA e61001fView commit details