Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft release notes for 0.0.123 #3012

Merged
merged 4 commits into from May 8, 2024

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (a27088d) to head (2804377).
Report is 27 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
+ Coverage   89.83%   90.57%   +0.73%     
==========================================
  Files         117      118       +1     
  Lines       96237   101950    +5713     
  Branches    96237   101950    +5713     
==========================================
+ Hits        86459    92340    +5881     
+ Misses       7215     7165      -50     
+ Partials     2563     2445     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt added this to the 0.0.123 milestone Apr 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

* `ChainMonitor::archive_fully_resolved_channel_monitors` is now provided to
remove `ChannelMonitor`s from memory which have been fully resolved on-chain
and now are not needed. It uses the new `Persist::archive_persisted_channel`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/now are not/are no longer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, causes the whole block to run another line...

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
`ChannelManager::accept_inbound_channel` would previously have stalled from
the peer's perspective as no `error` message was sent (#2953).
* Blinded path construction has been tuned to select paths more likely to
succeed, improving BOLT12 payment reliability (#2911, #2912, XXX?).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is another PR expected here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, sorry, I had recalled there being one but I'm wrong.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
* `ChannelManager` deserialization may now fail with `DangerousValue` when
LDK's persistence API was violated (#2974).

## Bug Fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3021, #2971, #2951 could be mentioned?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3021 - yea, this PR is older than that one, I'll go ahead and rebase it and add more PRs now.
2971 - it feels pretty internal implementation detail, I'm not sure I could concretely describe in a useful way what it fixes for users.
2951 - this too seems to fix a case that isn't super relevant usually. Its really only interesting in certain regtest setups where you're using non-announced introduction nodes.

@TheBlueMatt TheBlueMatt force-pushed the 2024-04-0.0.123-rl branch 2 times, most recently from 23db855 to 50fb43c Compare May 7, 2024 18:51
@TheBlueMatt
Copy link
Collaborator Author

Added update for #3045

CHANGELOG.md Outdated Show resolved Hide resolved
BOLT11 invoices containing non-ASCII characters are invalid.

In total, this release features 150 files changed, 19307 insertions, 6306
deletions in 360 commits since 0.0.121 from 17 authors, in alphabetical order:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/121/122?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because 122 branched its annoying to try to figure out so I just did it against 121.

I'd uploaded `possiblyrandom` 0.1 to reserve the crate name but
with a dummy library so now we need ot use 0.2 for the release.
@TheBlueMatt TheBlueMatt merged commit 74c9f9b into lightningdevkit:main May 8, 2024
5 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants