Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Retry InvoiceRequest Flow #3010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Introduce Retry InvoiceRequest Flow #3010

wants to merge 4 commits into from

Commits on May 13, 2024

  1. Introduce InvoiceRequest as a field in AwaitingInvoice. 

    This will be used to recreate InvoiceRequest messages for retries for
the payments that are still awaiting receiving an invoice.
    @shaavan
    shaavan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7fd7364 View commit details
    Browse the repository at this point in the history

  2. Introduce retry_invoice_request_messages function 

    We need to retry InvoiceRequest messages in a smaller time duration
than timer_tick_occurred. This function provides the base for doing
the retry, by getting the InvoiceRequest for PendingOutboundPayments
and using a new reply_path to create and enqueue InvoiceRequest messages.
    @shaavan
    shaavan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1dff554 View commit details
    Browse the repository at this point in the history

  3. Introduce retry_invoice_request_message code within timer_tick_occurred. 

    1. And introduce static CALL_COUNTER, to trigger the `timer_tick_occurred`
   code only every 10th call.
2. Decrease Freshness timer duration.
3. This is done so that `retry_invoice_request_messages` can be called faster
   than the rest of the code without introducing a secondary timer.
    @shaavan
    shaavan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f3efda6 View commit details
    Browse the repository at this point in the history

  4. Introduce test for retry_tick_occurred

    @shaavan
    shaavan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    65b0fa3 View commit details
    Browse the repository at this point in the history