Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize blinded Trampoline hops #3007

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Apr 19, 2024

Add BlindedForward and BlindedReceive variants to OutboundTrampolinePayload.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.94340% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 90.17%. Comparing base (ac9a2c8) to head (67ecd63).
Report is 39 commits behind head on main.

Files Patch % Lines
lightning/src/ln/msgs.rs 50.94% 22 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
+ Coverage   89.42%   90.17%   +0.75%     
==========================================
  Files         117      118       +1     
  Lines       96290   104734    +8444     
  Branches    96290   104734    +8444     
==========================================
+ Hits        86109    94449    +8340     
- Misses       7962     8125     +163     
+ Partials     2219     2160      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, why is this draft? What's it waiting on?

@@ -1767,6 +1768,21 @@ mod fuzzy_internal_msgs {
outgoing_cltv_value: u32,
/// The node id to which the trampoline node must find a route
outgoing_node_id: PublicKey,
},
#[allow(unused)]
BlindedForward {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some docs, what does BlindedForward and BlindedReceive actually mean?

@arik-so arik-so mentioned this pull request Apr 22, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants