Trampoline Onion Deserialization #3006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Apr 22, 2024
lightning/src/ln/msgs.rs
Outdated
Comment on lines
1870
to
1875
| while read_idx < hop_data_len { | ||
| let mut read_buffer = [0; READ_BUFFER_SIZE]; | ||
| let read_amt = cmp::min(hop_data_len - read_idx, READ_BUFFER_SIZE); | ||
| r.read_exact(&mut read_buffer[..read_amt])?; | ||
| hop_data.extend_from_slice(&read_buffer[..read_amt]); | ||
| read_idx += read_amt; |
There was a problem hiding this comment.
Can we just use WithoutLength<Vec<u8>>?
There was a problem hiding this comment.
To clarify, you mean using WithoutLength with some sort of length-limiting mechanism like read_exact? Such that it doesn't run over into reading the HMAC?
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-onion-deserialization
branch
from
25fffeb
to
1fd3b34
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
==========================================
+ Coverage 89.42% 90.24% +0.81%
==========================================
Files 117 118 +1
Lines 96290 105246 +8956
Branches 96290 105246 +8956
==========================================
+ Hits 86109 94979 +8870
- Misses 7962 8100 +138
+ Partials 2219 2167 -52 ☔ View full report in Codecov by Sentry. |
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-onion-deserialization
branch
from
1fd3b34
to
091cc6d
Compare
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-onion-deserialization
branch
from
091cc6d
to
325d93b
Compare
TheBlueMatt
reviewed
May 6, 2024
Comment on lines
+1864
to
+1865
| let hop_data_len = r.total_bytes().saturating_sub(66) as usize; // 1 (version) + 33 (pubkey) + 32 (HMAC) = 66 | ||
| let mut rd = FixedLengthReader::new(r, hop_data_len as u64); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement deserialization using LengthReadable.