Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make event handling fallible #2995

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make event handling fallible #2995

wants to merge 2 commits into from
+257 −181

Commits on Jun 3, 2024

  1. Make event handling fallible 

    Previously, we would require our users to handle all events
successfully inline or panic will trying to do so. If they would exit
the `EventHandler` any other way we'd forget about the event and
wouldn't replay them after restart.

Here, we implement fallible event handling, allowing the user to return
`Err(())` which signals to our event providers they should abort event
processing and replay any unhandled events later (i.e., in the next
invocation).
    @tnull
    tnull committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    266ef70 View commit details
    Browse the repository at this point in the history

  2. f Use ReplayEvent unit struct error type

    @tnull
    tnull committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    772a851 View commit details
    Browse the repository at this point in the history