Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the channel state before restarting the channel establishment process. #2983

Closed
wants to merge 4 commits into from
Closed

Reset the channel state before restarting the channel establishment process. #2983

wants to merge 4 commits into from

Commits on Apr 24, 2024

  1. Add a new field to OutboundV1Channel 

    1. This field saves info about the previously received AcceptChannel
   and previously created FundingTransaction.
    @shaavan
    shaavan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    dd83080 View commit details
    Browse the repository at this point in the history

  2. Update get_open_channel flow. 

    - If our channel_state has moved forward, we check if it is at the
  negotiation stage, and that we have access to previously received
  accept_channel_msg. We panic only when both conditions fail.
    @shaavan
    shaavan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    080c90b View commit details
    Browse the repository at this point in the history

  3. Update accept_channel flow. 

    1. If we had an acceptchannel earlier, we check if it matches the one
   received just now. If not we error, because the channel parameters
   have changed and that warrants renegotiating parameters again.
2. If they do match we simply skip the rest of the function because we
   had updated those values already.
    @shaavan
    shaavan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4fb0352 View commit details
    Browse the repository at this point in the history

  4. Update get_funding_created flow. 

    - Introduce a new enum that tracks if the Funding Transaction is a
  previously received transaction or a newly created one.
- Update the flow and sanity checks accordingly to allow using
  previously used transaction if present.
    @shaavan
    shaavan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    3dfc379 View commit details
    Browse the repository at this point in the history