Support sending custom TLVs to to blinded recipients #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
previously approved these changes
Mar 27, 2024
57 tasks
valentinewallace
force-pushed
the
2024-03-blinded-path-custom-tlvs
branch
from
9d896eb
to
cb022c5
Compare
|
Updated to fix unrelated test failure. |
|
Lets find this a second reviewer. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
- Coverage 89.49% 89.49% -0.01%
==========================================
Files 117 117
Lines 95148 96650 +1502
Branches 95148 96650 +1502
==========================================
+ Hits 85152 86495 +1343
- Misses 7780 7859 +79
- Partials 2216 2296 +80 ☔ View full report in Codecov by Sentry. |
arik-so
reviewed
Mar 29, 2024
arik-so
approved these changes
Mar 29, 2024
valentinewallace
merged commit 51926f1
into
lightningdevkit:main
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on reviving my patch for #2201 and figured it might make sense to do this first, to allow that patch to account for custom TLVs to blinded recipients.
Wrote this before remembering that #2830 exists, but I believe they don't conflict because this is for sender-set custom TLVs, and #2830 seems to be for including custom TLVs inside blinded paths (i.e. for the recipient to provide back to themselves).