New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Readable
for Offer
and Refund
#2965
base: main
Are you sure you want to change the base?
Implement Readable
for Offer
and Refund
#2965
Conversation
When storing `Offer`s, it's useful for them to implement LDK's deserialization trait.
When storing `Refund`s, it's useful for them to implement LDK's deserialization trait.
I believe the intended serialization for all of this is |
Hmmm, but for example in LDK Node's upcoming |
Yea, I mean I'm okay with supporting more here, just noting that we've historically just suggested string'ifying the BOLT11 things. |
Is it desirable to parse the offer into all of its in-memory parts? Like, if you were listing most recent payments, showing the bech32 string might be more desirable, only parsing it when examining a specific payment. I guess I don't have a strong feeling about whether we should add |
Hmm, so far the payment store holds and returns the full Rust objects, which would allow users to take advantage of the full API. While I agree that for display purposes showing the bech32 could make more sense, it would still be good to maintain easy access to any of the provided |
In order to make storing
Offer
andRefund
objects easier, we here implementReadable
for them (both already implementWriteable
).As I'm not sure if this was omitted on purpose so far, waiting on a concept ACK from @jkczyz.
If we agree we want this, we should probably also implement
Writeable
/Readable
forBolt11Invoice
, and add serde de/serialization forOffer
/Refund
as requested here.