Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ResponseInstructions for OnionMessage Handling #2907

Merged
merged 2 commits into from
May 8, 2024

Commits on May 3, 2024

  1. Introduce ResponseInstructions for OnionMessage Handling

    - Currently, handle_message (or handle_custom_message) only exposes
      the generated response for an OnionMessage, lacking the necessary
      reply_path for asynchronous responses.
    
    - This commit introduces a new flow for OnionMessage handling.
    
    - Instead of solely taking the message as input, handle_message now accepts
      an Optional `responder`, returning a `ResponseInstruction` containing both
      the response and the reply_path.
    
    - `ResponseInstruction` utilizes different enum variants to indicate how
      `handle_onion_message_response` should handle the response.
    
    - This enhancement enables exposing the reply_path alongside the response
      and allows for more complex response mechanisms, such as responding with
      an added reply_path.
    
    - The commit introduces the foundational framework (structs & enums) for this new flow.
    shaavan committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e640951 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Implement ResponseInstruction Usage in OnionMessage Handling

    This commit integrates the newly introduced ResponseInstruction structs
    and enums into the codebase for handling OnionMessage responses.
    shaavan committed May 8, 2024
    Configuration menu
    Copy the full SHA
    15d016a View commit details
    Browse the repository at this point in the history