Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payment onion payload decode #1659

Merged
merged 3 commits into from Aug 15, 2022
Merged

Fix payment onion payload decode #1659

merged 3 commits into from Aug 15, 2022

Commits on Aug 6, 2022

  1. Minor msgs::OnionHopData cleanups

    @valentinewallace
    valentinewallace committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    dcef41d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Fix bug in onion payment payload decode 

    Prior to this change, we could have failed to decode a valid payload of size
>253. This is because we were decoding the length (a BigSize, big-endian) as a
VarInt (little-endian).

Found in lightningdevkit#1652.
    @valentinewallace
    valentinewallace committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    a23681f View commit details
    Browse the repository at this point in the history

  2. Rename HighZeroBytesDroppedVarInt to HighZeroBytesDroppedBigSize 

    As observed by @wpaulino, this struct encodes its bytes as big-endian,
therefore it's a BigSize, not a VarInt.
    @valentinewallace
    valentinewallace committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    dfbebbf View commit details
    Browse the repository at this point in the history