Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss/Do #2970 followups #3002

Closed
TheBlueMatt opened this issue Apr 18, 2024 · 1 comment · Fixed by #3028
Closed

Discuss/Do #2970 followups #3002

TheBlueMatt opened this issue Apr 18, 2024 · 1 comment · Fixed by #3028
Milestone
0.0.123

Comments

@TheBlueMatt
Copy link
Collaborator

#2970 (review)
@TheBlueMatt TheBlueMatt added this to the 0.0.123 milestone Apr 18, 2024
@TheBlueMatt
Copy link
Collaborator Author

Also need to note in release notes that we can't downgrade after receiving bolt12 payments with 0.0.123.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Apr 25, 2024
@TheBlueMatt
Drop amount_msats from InvoiceRequestFields
90c919c 
An `InvoiceRequest` can overpay for an `Offer` which would be
reflected back to the recipient via the `amount_msats` field, but
its somewhat deceptive as the sender can *also* then further
overpay in the HTLC(s) themselves. The total overpayment is already
communicated in the `Event::ClaimablePayment` so we simply drop the
`InvoiceRequestFields` field here.

Fixes lightningdevkit#3002
@TheBlueMatt TheBlueMatt mentioned this issue Apr 25, 2024
Closed
@TheBlueMatt TheBlueMatt linked a pull request Apr 29, 2024 that will close this issue
Follow-ups to #2970 #3028
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.123
Development

Successfully merging a pull request may close this issue.

Follow-ups to #2970 jkczyz/rust-lightning
#2970 Followups TheBlueMatt/rust-lightning
1 participant
@TheBlueMatt