Refactor channelmanager tests into more appropriate submodule tests #2977
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
- Coverage 89.33% 89.09% -0.24%
==========================================
Files 117 121 +4
Lines 95618 97509 +1891
Branches 95618 97509 +1891
==========================================
+ Hits 85417 86879 +1462
- Misses 7952 8383 +431
+ Partials 2249 2247 -2 ☔ View full report in Codecov by Sentry. |
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
8eda436
to
388e6bc
Compare
There was a problem hiding this comment.
Note that you'll probably have to rebase this after #2731 adds a new test.
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
388e6bc
to
e75b405
Compare
Will take care of that for sure 👍 |
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
e75b405
to
30dcf01
Compare
|
@TheBlueMatt updated changes from main after the merge of #2731 Took care of added test |
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
30dcf01
to
f585d35
Compare
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
f585d35
to
e50313f
Compare
* Few tests were dependent on channelmanagers internal state, refactored that them to publicly visible apis
srikanth-iyengar
force-pushed
the
refactor/2958
branch
from
e50313f
to
77fc367
Compare
| #[test] | ||
| fn bad_inbound_payment_hash() { | ||
| // Add coverage for checking that a user-provided payment hash matches the payment secret. | ||
| let chanmon_cfgs = create_chanmon_cfgs(2); | ||
| let node_cfgs = create_node_cfgs(2, &chanmon_cfgs); | ||
| let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]); | ||
| let nodes = create_network(2, &node_cfgs, &node_chanmgrs); | ||
| node_cfgs[0].keys_manager.get_inbound_payment_key_material(); | ||
|
|
||
| let highest_seen_timestamp = bitcoin::blockdata::constants::genesis_block(bitcoin::Network::Testnet).header.time; | ||
| let node_signer = node_cfgs[0].keys_manager; | ||
| let inbound_pmt_key_material = node_signer.get_inbound_payment_key_material(); | ||
| let expanded_inbound_key = inbound_payment::ExpandedKey::new(&inbound_pmt_key_material); | ||
|
|
||
| let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(&nodes[0]); | ||
| let payment_data = msgs::FinalOnionHopData { | ||
| payment_secret, | ||
| total_msat: 100_000, | ||
| }; | ||
|
|
||
|
|
There was a problem hiding this comment.
@TheBlueMatt I have refactored this test, can you go through this whether this behaves as expected ?
There was a problem hiding this comment.
Basically I tried to untie the dependency between the channelmanagers internal state, let me know if there is better way
| // Should we drop this check ? | ||
| // Assert that ChannelUpdate message has been added to node[0] pending broadcast messages | ||
| // let pending_broadcast_messages = nodes[0].node.get_and_clear_pending_msg_events(); | ||
| // assert_eq!(pending_broadcast_messages.len(), 2); | ||
| } |
There was a problem hiding this comment.
@TheBlueMatt I had to remove this check, because this effects the at the 703-704 and fails
I am not able to figure out the reason why this is happening
|
This might need a rebase by now - sorry! |
Thanks, will rebase with main. |
Fix #2958
Previously
channelmanagerhad a single test module withintchannelmanager.rsThis changes introduces moving refactoring
23tests ofchannelmanagerinto following test groupsGroup 1: Key Send and Payment Verification
Group 2: Channel Management and Limits
Group 3: Anchor Channel and Configuration Tests