Skip to content

Commit

Permalink
format channelmanager tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@srikanth-iyengar
srikanth-iyengar committed Apr 5, 2024
1 parent d30d22e commit 30dcf01
Show file tree
Hide file tree
Showing 3 changed files with 1,165 additions and 342 deletions.
176 changes: 135 additions & 41 deletions lightning/src/ln/anchor_channel_configuration_tests.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,23 @@ fn test_inbound_anchors_manual_acceptance() {

let chanmon_cfgs = create_chanmon_cfgs(3);
let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs,
&[Some(anchors_cfg.clone()), Some(anchors_cfg.clone()), Some(anchors_manual_accept_cfg.clone())]);
let user_cfgs = [
Some(anchors_cfg.clone()),
Some(anchors_cfg.clone()),
Some(anchors_manual_accept_cfg.clone()),
];
let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &user_cfgs);
let nodes = create_network(3, &node_cfgs, &node_chanmgrs);

nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 0, 42, None, None).unwrap();
let open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
nodes[0]
.node
.create_channel(nodes[1].node.get_our_node_id(), 100_000, 0, 42, None, None)
.unwrap();
let open_channel_msg = get_event_msg!(
nodes[0],
MessageSendEvent::SendOpenChannel,
nodes[1].node.get_our_node_id()
);

nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
Expand All @@ -32,19 +43,22 @@ fn test_inbound_anchors_manual_acceptance() {
MessageSendEvent::HandleError { node_id, action } => {
assert_eq!(*node_id, nodes[0].node.get_our_node_id());
match action {
ErrorAction::SendErrorMessage { msg } =>
assert_eq!(msg.data, "No channels with anchor outputs accepted".to_owned()),
ErrorAction::SendErrorMessage { msg } => {
assert_eq!(msg.data, "No channels with anchor outputs accepted".to_owned())
},
_ => panic!("Unexpected error action"),
}
}
},
_ => panic!("Unexpected event"),
}

nodes[2].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
let events = nodes[2].node.get_and_clear_pending_events();
match events[0] {
Event::OpenChannelRequest { temporary_channel_id, .. } =>
nodes[2].node.accept_inbound_channel(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 23).unwrap(),
Event::OpenChannelRequest { temporary_channel_id, .. } => nodes[2]
.node
.accept_inbound_channel(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 23)
.unwrap(),
_ => panic!("Unexpected event"),
}
get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
Expand All @@ -60,27 +74,54 @@ fn test_anchors_zero_fee_htlc_tx_fallback() {
let mut anchors_config = test_default_channel_config();
anchors_config.channel_handshake_config.negotiate_anchors_zero_fee_htlc_tx = true;
anchors_config.manually_accept_inbound_channels = true;
let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(anchors_config.clone()), Some(anchors_config.clone())]);
let user_cfgs = [Some(anchors_config.clone()), Some(anchors_config.clone())];
let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
let nodes = create_network(2, &node_cfgs, &node_chanmgrs);

nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 0, 0, None, None).unwrap();
let open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
assert!(open_channel_msg.common_fields.channel_type.as_ref().unwrap().supports_anchors_zero_fee_htlc_tx());
nodes[0]
.node
.create_channel(nodes[1].node.get_our_node_id(), 100_000, 0, 0, None, None)
.unwrap();
let open_channel_msg = get_event_msg!(
nodes[0],
MessageSendEvent::SendOpenChannel,
nodes[1].node.get_our_node_id()
);
assert!(open_channel_msg
.common_fields
.channel_type
.as_ref()
.unwrap()
.supports_anchors_zero_fee_htlc_tx());

nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
let events = nodes[1].node.get_and_clear_pending_events();
match events[0] {
Event::OpenChannelRequest { temporary_channel_id, .. } => {
nodes[1].node.force_close_broadcasting_latest_txn(&temporary_channel_id, &nodes[0].node.get_our_node_id()).unwrap();
}
nodes[1]
.node
.force_close_broadcasting_latest_txn(
&temporary_channel_id,
&nodes[0].node.get_our_node_id(),
)
.unwrap();
},
_ => panic!("Unexpected event"),
}

let error_msg = get_err_msg(&nodes[1], &nodes[0].node.get_our_node_id());
nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &error_msg);

let open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
assert!(!open_channel_msg.common_fields.channel_type.unwrap().supports_anchors_zero_fee_htlc_tx());
let open_channel_msg = get_event_msg!(
nodes[0],
MessageSendEvent::SendOpenChannel,
nodes[1].node.get_our_node_id()
);
assert!(!open_channel_msg
.common_fields
.channel_type
.unwrap()
.supports_anchors_zero_fee_htlc_tx());

// Since nodes[1] should not have accepted the channel, it should
// not have generated any events.
Expand All @@ -97,30 +138,64 @@ fn test_update_channel_config() {
let _ = create_announced_chan_between_nodes(&nodes, 0, 1);
let channel = &nodes[0].node.list_channels()[0];

nodes[0].node.update_channel_config(&channel.counterparty.node_id, &[channel.channel_id], &user_config.channel_config).unwrap();
nodes[0]
.node
.update_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id],
&user_config.channel_config,
)
.unwrap();
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 0);

user_config.channel_config.forwarding_fee_base_msat += 10;
nodes[0].node.update_channel_config(&channel.counterparty.node_id, &[channel.channel_id], &user_config.channel_config).unwrap();
assert_eq!(nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_base_msat, user_config.channel_config.forwarding_fee_base_msat);
nodes[0]
.node
.update_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id],
&user_config.channel_config,
)
.unwrap();
assert_eq!(
nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_base_msat,
user_config.channel_config.forwarding_fee_base_msat
);
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 1);
match &events[0] {
MessageSendEvent::BroadcastChannelUpdate { .. } => {},
_ => panic!("expected BroadcastChannelUpdate event"),
}

nodes[0].node.update_partial_channel_config(&channel.counterparty.node_id, &[channel.channel_id], &ChannelConfigUpdate::default()).unwrap();
nodes[0]
.node
.update_partial_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id],
&ChannelConfigUpdate::default(),
)
.unwrap();
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 0);

let new_cltv_expiry_delta = user_config.channel_config.cltv_expiry_delta + 6;
nodes[0].node.update_partial_channel_config(&channel.counterparty.node_id, &[channel.channel_id], &ChannelConfigUpdate {
cltv_expiry_delta: Some(new_cltv_expiry_delta),
..Default::default()
}).unwrap();
assert_eq!(nodes[0].node.list_channels()[0].config.unwrap().cltv_expiry_delta, new_cltv_expiry_delta);
nodes[0]
.node
.update_partial_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id],
&ChannelConfigUpdate {
cltv_expiry_delta: Some(new_cltv_expiry_delta),
..Default::default()
},
)
.unwrap();
assert_eq!(
nodes[0].node.list_channels()[0].config.unwrap().cltv_expiry_delta,
new_cltv_expiry_delta
);
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 1);
match &events[0] {
Expand All @@ -129,12 +204,25 @@ fn test_update_channel_config() {
}

let new_fee = user_config.channel_config.forwarding_fee_proportional_millionths + 100;
nodes[0].node.update_partial_channel_config(&channel.counterparty.node_id, &[channel.channel_id], &ChannelConfigUpdate {
forwarding_fee_proportional_millionths: Some(new_fee),
..Default::default()
}).unwrap();
assert_eq!(nodes[0].node.list_channels()[0].config.unwrap().cltv_expiry_delta, new_cltv_expiry_delta);
assert_eq!(nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths, new_fee);
nodes[0]
.node
.update_partial_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id],
&ChannelConfigUpdate {
forwarding_fee_proportional_millionths: Some(new_fee),
..Default::default()
},
)
.unwrap();
assert_eq!(
nodes[0].node.list_channels()[0].config.unwrap().cltv_expiry_delta,
new_cltv_expiry_delta
);
assert_eq!(
nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths,
new_fee
);
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 1);
match &events[0] {
Expand All @@ -145,19 +233,25 @@ fn test_update_channel_config() {
// If we provide a channel_id not associated with the peer, we should get an error and no updates
// should be applied to ensure update atomicity as specified in the API docs.
let bad_channel_id = ChannelId::v1_from_funding_txid(&[10; 32], 10);
let current_fee = nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths;
let current_fee =
nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths;
let new_fee = current_fee + 100;
assert!(
matches!(
nodes[0].node.update_partial_channel_config(&channel.counterparty.node_id, &[channel.channel_id, bad_channel_id], &ChannelConfigUpdate {
assert!(matches!(
nodes[0].node.update_partial_channel_config(
&channel.counterparty.node_id,
&[channel.channel_id, bad_channel_id],
&ChannelConfigUpdate {
forwarding_fee_proportional_millionths: Some(new_fee),
..Default::default()
}),
Err(APIError::ChannelUnavailable { err: _ }),
)
);
}
),
Err(APIError::ChannelUnavailable { err: _ }),
));
// Check that the fee hasn't changed for the channel that exists.
assert_eq!(nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths, current_fee);
assert_eq!(
nodes[0].node.list_channels()[0].config.unwrap().forwarding_fee_proportional_millionths,
current_fee
);
let events = nodes[0].node.get_and_clear_pending_msg_events();
assert_eq!(events.len(), 0);
}

0 comments on commit 30dcf01

Please sign in to comment.