Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow:add checkout parameters to fix inconsistent build failures #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RandyMcMillan
Copy link

No description provided.

@RandyMcMillan
Copy link
Author

@TheBlueMatt
Copy link
Contributor

The error upstream was "fatal: unable to access 'https://github.com/lightningdevkit/ldk-sample/': Could not resolve host: github.com". I don't see how this fixes the error of "sorry, not connected to the internet"?

@RandyMcMillan
Copy link
Author

I have found that if git doesn't recognize a repo as safe...it blocks requests.
So the error may be being misinterpreted by GitHub?

@TheBlueMatt
Copy link
Contributor

I'm somewhat skeptical, my PR at https://github.com/lightningdevkit/ldk-sample/actions/runs/7806655220/job/21293476669?pr=129 just passed fine. We've seen github MacOS runners not have internet connectivity sporadically repeatedly in other LDK projects, though, so I think the bug actually lies on GitHub's end. Unless there's some other reference to this issue I'm not aware of.

@RandyMcMillan RandyMcMillan changed the title workflow:add checkout parameters to fix macos-latest build workflow:add checkout parameters to fix inconsistent build failures Feb 6, 2024
@RandyMcMillan
Copy link
Author

I understand your skepticism. Whenever I create a workflow - I just automatically put it in there. So it isn't even an issue.
Feel free to gank the commit and try it on other repos YOU are seeing this intermittent issue on - with no real explanation or solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants