-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anchor support #141
Open
tnull
wants to merge
12
commits into
lightningdevkit:main
Choose a base branch
from
tnull:2023-07-add-anchor-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add anchor support #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
October 5, 2023 19:29
340cdd5
to
405dcec
Compare
Rebased on #151. |
Merged
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
December 21, 2023 17:23
405dcec
to
08ba6e0
Compare
Rebased on current main. Still need to expose a good API. |
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
December 21, 2023 18:56
08ba6e0
to
3bc7c2d
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
January 17, 2024 13:58
3bc7c2d
to
0387783
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
February 5, 2024 11:29
0387783
to
1fecf85
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
11 times, most recently
from
February 19, 2024 15:27
a6bdd44
to
8a01a2e
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
2 times, most recently
from
February 20, 2024 10:35
2741cf9
to
1510751
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
April 12, 2024 09:27
f3ce853
to
003f52b
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
May 13, 2024 17:18
003f52b
to
2e29945
Compare
Rebased on current #270. |
tnull
force-pushed
the
2023-07-add-anchor-support
branch
2 times, most recently
from
May 15, 2024 14:14
f801c06
to
ddbbdc0
Compare
Rebased on main after #270 landed. |
tnull
force-pushed
the
2023-07-add-anchor-support
branch
6 times, most recently
from
May 17, 2024 12:42
d1ed40e
to
4d87da7
Compare
.. allowing to configure the per-channel emergency reserve as well as some trusted peers for which we won't maintain any reserve.
When Anchor outputs need to be spent LDK will generate `BumpTransactionEvent`s. Here, we add the corresponding event-handling and PSBT-signing support.
.. as LDK doesn't provide the `non_witness_utxo` in the PSBT
.. because they will be the new default. Note the upcoming CLN 24.02 release will make Anchors default, too, but for now we have to set the `experimental-anchors` config option.
.. which we somehow so far ommitted exposing in the API. We now introduce a `force` flag to `close_channel` and broadcast if the counterparty is not trusted.
.. i.e., without bumping.
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
May 27, 2024 08:23
4d87da7
to
b0a9d89
Compare
tnull
force-pushed
the
2023-07-add-anchor-support
branch
from
May 27, 2024 08:35
b0a9d89
to
2d45314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
#243,#250, #253.