CSharp: fix LDKStr array decoding #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings are encoded as array of string references, those references are actually pointers to the string location and have 64bit in size, but decoding logic was decoding those pointers as 32bit which caused the following exception, this commit fixes that. Exception: Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. at InternalUtils.getArrayLength(Int64) at InternalUtils.decodeUint8Array(Int64) at InternalUtils.decodeString(Int64) at org.ldk.structs.Result_CVec_StrZIOErrorZ+Result_CVec_StrZIOErrorZ_OK..ctor(System.Object, Int64) at org.ldk.structs.Result_CVec_StrZIOErrorZ.constr_from_ptr(Int64) at org.ldk.structs.KVStore.list(System.String, System.String)
TheBlueMatt
reviewed
Mar 12, 2024
| @@ -581,7 +581,7 @@ def get_java_arr_elem(self, elem_ty, arr_name, idx): | |||
| elif elem_ty.rust_obj == "LDKU5": | |||
| return "InternalUtils.getU8ArrayElem(" + arr_name + ", " + idx + ")" | |||
| elif elem_ty.rust_obj == "LDKStr": | |||
| return "InternalUtils.getU32ArrayElem(" + arr_name + ", " + idx + ")" | |||
| return "InternalUtils.getU64ArrayElem(" + arr_name + ", " + idx + ")" | |||
There was a problem hiding this comment.
nit: mind just including it in the first if (or breaking the pointer array ones into a second if)? Its really a pointer array and should be grouped with the if for pointer arrays (endswith("Array") || c_ty == "uintptr_t").
TheBlueMatt
reviewed
Mar 12, 2024
|
Eh, I'll just merge this since I want to do a new round of releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings are encoded as array of string references, those references are actually pointers to the string location and have 64bit in size, but decoding logic was decoding those pointers as 32bit which caused the following exception, this commit fixes that.
Exception:
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at InternalUtils.getArrayLength(Int64)
at InternalUtils.decodeUint8Array(Int64)
at InternalUtils.decodeString(Int64)
at org.ldk.structs.Result_CVec_StrZIOErrorZ+Result_CVec_StrZIOErrorZ_OK..ctor(System.Object, Int64)
at org.ldk.structs.Result_CVec_StrZIOErrorZ.constr_from_ptr(Int64)
at org.ldk.structs.KVStore.list(System.String, System.String)