Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all heading levels consistent #1080

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jirijakes
Copy link

With this change, all documents have a single level-1 heading (document title), all other headings are at least level 2.

Rationale

I wish to export documents to other formats (using pandoc). Unfortunately, levels of headings were used inconsistently across the documents, which made automated export quite complicated. This change makes all headings consistent with 00-introduction.md and 01-messaging.md.

Headings were shifted down by one level, a few did not require any change. Links to sections remain the same, therefore no references to the bolts and their sections should be broken.

@ProofOfKeags
Copy link
Contributor

Concept ACK

Seems like you should also specify this requirement in the CONTRIBUTING.md

Also this is the type of thing you probably need a GitHub workflow to enforce, it's hard to review PR's at a glance and ensure they meet this requirement

@jirijakes
Copy link
Author

Seems like you should also specify this requirement in the CONTRIBUTING.md
Also this is the type of thing you probably need a GitHub workflow to enforce

Thanks, @ProofOfKeags , good ideas. I will look into it.

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK a59746d

@jirijakes jirijakes marked this pull request as draft February 23, 2024 16:21
Previously, levels of headings were used inconsistently across the
documents, which made automated export to other formats complicated.
With this change, all documents have single level 1 heading (title of
the document) and all other headings are at least level 2.
Commit introduces initial set of rules for checking formatting of
markdown files as part of GitHub workflow. The rules are:

  - first line is top-level heading
  - there is only one top-level heading in the document
@jirijakes
Copy link
Author

Changes:

@jirijakes jirijakes marked this pull request as ready for review February 23, 2024 23:40
Copy link
Contributor

@ProofOfKeags ProofOfKeags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thanks for the cleanup and infrastructure to maintain it 🪴

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c1f8a9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants