fix: upgrade knex from 2.4.0 to 2.4.2 #4309
Conversation
Also fixes new warnings with double rollbacks in transaction blocks
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
owlas
requested a deployment
to
fix/patch-knex - jaffle_db PR #4309
Render
Abandoned
owlas
temporarily deployed
to
fix/patch-knex - headless-browser PR #4309
Render
Destroyed
owlas
temporarily deployed
to
fix/patch-knex - lightdash PR #4309
Render
Destroyed
| }), | ||
| ); | ||
| } catch (e) { | ||
| trx.rollback(e); |
There was a problem hiding this comment.
why don't we want those rollbacks ? are they applied automatically ?
There was a problem hiding this comment.
yes, knex handles that for us. This was a bad practice when we started using knex.
There was a problem hiding this comment.
That's right! About half way down this page: https://knexjs.org/guide/transactions.html
And in dev when the error happened it was inside this transaction block. And the knex threw another error (hiding the real one) saying "you're trying to exit a transaction that has already been closed" (or something like that).
This fixed the dev experience. It doesn't seem to happen in production though, which is curious
## [0.395.1](0.395.0...0.395.1) (2023-01-27) ### Bug Fixes * upgrade knex from 2.4.0 to 2.4.2 ([#4309](#4309)) ([4bb578c](4bb578c))
|
🎉 This PR is included in version 0.395.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Also fixes new warnings with double rollbacks in transaction blocks
2.4.0 contains a bug when inserting arrays: knex/knex#5365
Reviewing
The diff looks big but I've only made two changes:
try {} except {trx.rollback(e); throw e;}from a bunch of transacting blocks